Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Proofread finished for the core directory#1

Merged
Ivoz merged 13 commits into
OpenTechSchool:gh-pagesfrom
thatbettina:gh-pages
Oct 8, 2013
Merged

Proofread finished for the core directory#1
Ivoz merged 13 commits into
OpenTechSchool:gh-pagesfrom
thatbettina:gh-pages

Conversation

@thatbettina
Copy link
Copy Markdown
Contributor

FYI: Portfolio 2 is still missing some stuff, like form elements.

Comment thread index.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remark seems kinda lost. Can we further explain it, or at least say we're deferring the explanation of this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lehmannro This might be a better remark for @gsambrotta because she wrote the text; I am just proofreading it as a native English speaker.

@lehmannro
Copy link
Copy Markdown

Line lengths are now a mumbo jumbo between capped-to-80-characters, 80-characters-plus-some-edits, and whole-paragraph-in-one-line. Could we rewrap?

Comment thread core/portfolio-2.md Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better encourage a semicolon here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lehmannro Where should the semicolon be?

@Ivoz
Copy link
Copy Markdown
Member

Ivoz commented Sep 23, 2013

@thatbettina it would be awesome if you could work on updating the fixes that Robert has suggested, he has done so through your changes. If you just push commits to your repo it will update the pull request with them here.

Otherwise I'd love to start working on this tutorial as well, but it would probably be easier if we can get your changes in beforehand.

You should be able to get my quick commit in with a git pull --rebase, I hadn't noticed this large PQ coming up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants